Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NetCDFF] Update to v4.6.0 and link to NetCDF v4.9 #4344

Merged
merged 2 commits into from
Oct 15, 2022

Conversation

giordano
Copy link
Member

No description provided.

@giordano giordano added the Windows 🙄 Doesn't build for Windows label Jan 31, 2022
@giordano
Copy link
Member Author

giordano commented Jan 31, 2022

Quite frankly, I'm totally lost about the failure on Windows. configure is failing to compile this program

/* confdefs.h */
#define PACKAGE_NAME "netCDF-Fortran"
#define PACKAGE_TARNAME "netcdf-fortran"
#define PACKAGE_VERSION "4.5.4"
#define PACKAGE_STRING "netCDF-Fortran 4.5.4"
#define PACKAGE_BUGREPORT "[email protected]"
#define PACKAGE_URL ""
#define PACKAGE "netcdf-fortran"
#define VERSION "4.5.4"
#define NF_RELAX_COORD_BOUND 1
#define ENABLE_CDF5 1
#define HAVE_F2008 1
#define HAVE_TS29113_SUPPORT 1
#define TEMP_LARGE "."
#define HAVE_STDIO_H 1
#define HAVE_STDLIB_H 1
#define HAVE_STRING_H 1
#define HAVE_INTTYPES_H 1
#define HAVE_STDINT_H 1
#define HAVE_STRINGS_H 1
#define HAVE_SYS_STAT_H 1
#define HAVE_SYS_TYPES_H 1
#define HAVE_UNISTD_H 1
#define HAVE_SYS_TIME_H 1
#define STDC_HEADERS 1
#define LT_OBJDIR ".libs/"
#define _FILE_OFFSET_BITS 64
#define NF_INT1_T byte
#define NF_INT2_T integer*2
#define NF_INT8_T integer*8
#define NCBYTE_T byte
#define NCSHORT_T integer*2
#define HAVE_LIBM 1
#define HAVE_NETCDF_H 1
/* end confdefs.h.  */

/* Override any GCC internal prototype to avoid an error.
   Use char because int might match the return type of a GCC
   builtin and then its argument prototype would still apply.  */
char nc_open ();
int
main (void)
{
return nc_open ();
  ;
  return 0;
}

with the command

sandbox:${WORKSPACE}/srcdir/netcdf-fortran-4.5.4 # cc -std=gnu11 -o conftest.exe -g -O2   conftest.c -lnetcdf  -lm
/tmp/ccFGePlh.o: In function `main':
/workspace/srcdir/netcdf-fortran-4.5.4/conftest.c:44: undefined reference to `nc_open'
collect2: error: ld returned 1 exit status

but libnetcdf-19.dll has the symbol:

sandbox:${WORKSPACE}/srcdir/netcdf-fortran-4.5.4 # nm ${libdir}/libnetcdf-19.dll | grep '\<nc_open\>'
0000000066f4601b T nc_open

So why would it fail??

Edit additional datapoints:

  • netcdff 4.5.3 with netcdf 4.7 works
  • netcdff 4.5.3 with netcdf 4.8 doesn't work either, so I'm starting to suspect there is something wrong with the windows build of netcdf 4.8, but I can't quite understand what

Edit 2: #3731 looks relevant.

@giordano giordano marked this pull request as draft February 4, 2022 13:58
@giordano giordano marked this pull request as ready for review October 15, 2022 00:38
@giordano giordano changed the title [NetCDFF] Update to v4.5.4 and link to NetCDF v4.8 [NetCDFF] Update to v4.6.0 and link to NetCDF v4.9 Oct 15, 2022
@giordano giordano merged commit 0d10b8e into JuliaPackaging:master Oct 15, 2022
@giordano giordano deleted the mg/netcdff branch October 15, 2022 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Windows 🙄 Doesn't build for Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant